-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Kotlin compatibility for SdkVersion class #1213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
requested review from
bruno-garcia and
maciejwalkowiak
as code owners
January 29, 2021 10:30
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #1213 +/- ##
============================================
- Coverage 74.57% 74.56% -0.01%
Complexity 1713 1713
============================================
Files 177 177
Lines 6029 6040 +11
Branches 600 599 -1
============================================
+ Hits 4496 4504 +8
- Misses 1256 1262 +6
+ Partials 277 274 -3
Continue to review full report at Codecov.
|
maciejwalkowiak
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Improve Kotlin compatibility for SdkVersion class
💡 Motivation and Context
getsentry/sentry-dart#287
Kotlin integrations will need to take care of null fields that are not null if not annotated
💚 How did you test it?
📝 Checklist
🔮 Next steps