Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kotlin compatibility for SdkVersion class #1213

Merged
merged 12 commits into from
Feb 1, 2021

Conversation

marandaneto
Copy link
Contributor

📜 Description

Improve Kotlin compatibility for SdkVersion class

💡 Motivation and Context

getsentry/sentry-dart#287
Kotlin integrations will need to take care of null fields that are not null if not annotated

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Jan 29, 2021

Codecov Report

Merging #1213 (c12c942) into main (a32a612) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1213      +/-   ##
============================================
- Coverage     74.57%   74.56%   -0.01%     
  Complexity     1713     1713              
============================================
  Files           177      177              
  Lines          6029     6040      +11     
  Branches        600      599       -1     
============================================
+ Hits           4496     4504       +8     
- Misses         1256     1262       +6     
+ Partials        277      274       -3     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/sentry/SentryEnvelopeHeaderAdapter.java 77.77% <60.00%> (-1.30%) 18.00 <0.00> (ø)
...y/src/main/java/io/sentry/protocol/SdkVersion.java 68.57% <63.15%> (-13.25%) 10.00 <6.00> (+1.00) ⬇️
...rc/main/java/io/sentry/protocol/SentryPackage.java 57.14% <75.00%> (-20.64%) 4.00 <2.00> (-1.00)
...jul/src/main/java/io/sentry/jul/SentryHandler.java 73.10% <100.00%> (+1.20%) 31.00 <0.00> (ø)
...src/main/java/io/sentry/log4j2/SentryAppender.java 84.61% <100.00%> (+2.11%) 19.00 <0.00> (ø)
...rc/main/java/io/sentry/logback/SentryAppender.java 89.18% <100.00%> (+2.34%) 21.00 <0.00> (ø)
...io/sentry/spring/boot/SentryAutoConfiguration.java 97.95% <100.00%> (+3.84%) 1.00 <0.00> (ø)
...main/java/io/sentry/spring/SentryHubRegistrar.java 95.00% <100.00%> (+4.52%) 7.00 <0.00> (ø)
sentry/src/main/java/io/sentry/SentryOptions.java 84.64% <100.00%> (-0.06%) 115.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a32a612...c12c942. Read the comment docs.

@marandaneto marandaneto merged commit f8332e8 into main Feb 1, 2021
@marandaneto marandaneto deleted the enha/sdk-version-kotlin branch February 1, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants