Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Kotlin property access in Performance API. #1193

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Improve Kotlin property access in Performance API.

💡 Motivation and Context

Let users use property access instead of setters where its suitable.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

@codecov-io
Copy link

Codecov Report

Merging #1193 (296280e) into main (fc69ce7) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1193      +/-   ##
============================================
- Coverage     74.70%   74.57%   -0.14%     
+ Complexity     1677     1676       -1     
============================================
  Files           176      176              
  Lines          5887     5895       +8     
  Branches        574      574              
============================================
- Hits           4398     4396       -2     
- Misses         1225     1235      +10     
  Partials        264      264              
Impacted Files Coverage Δ Complexity Δ
sentry/src/main/java/io/sentry/NoOpSpan.java 11.76% <0.00%> (-2.53%) 2.00 <0.00> (ø)
...entry/src/main/java/io/sentry/NoOpTransaction.java 18.51% <0.00%> (-2.32%) 5.00 <0.00> (ø)
...try/src/main/java/io/sentry/SentryTransaction.java 95.00% <0.00%> (-3.28%) 29.00 <0.00> (ø)
...entry/src/main/java/io/sentry/SentryBaseEvent.java 86.84% <0.00%> (-5.27%) 20.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc69ce7...296280e. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit 7c2dbdb into main Jan 21, 2021
@maciejwalkowiak maciejwalkowiak deleted the improve-kotlin-property-access branch January 21, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants