Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "debug" through external properties. #1186

Merged
merged 5 commits into from
Jan 20, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Allows setting "debug" through external properties.

💡 Motivation and Context

Useful when debugging Spring (non-boot) integration.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we get away with boolean and default to false? You only need to set the value if it's true anyway (since we always have it false)

@maciejwalkowiak
Copy link
Contributor Author

@bruno-garcia practically yes, but theoretically there can be a case when it is set to true in the code and then turned off in external configuration.

@maciejwalkowiak maciejwalkowiak merged commit c3b9cf7 into main Jan 20, 2021
@maciejwalkowiak maciejwalkowiak deleted the external-properties-debug branch January 20, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants