Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify registering traces sample callback #1184

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Simplify registering traces sample callback in Spring integration.

💡 Motivation and Context

Similar to how TracesSamplerCallback is auto-configured in Spring Boot integration, Spring integration should detect if such bean exits and if so, set it on SentryOptions.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

@codecov-io
Copy link

Codecov Report

Merging #1184 (d8fe77b) into main (9e98134) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1184      +/-   ##
============================================
+ Coverage     75.31%   75.33%   +0.01%     
  Complexity     1669     1669              
============================================
  Files           173      173              
  Lines          5826     5829       +3     
  Branches        571      571              
============================================
+ Hits           4388     4391       +3     
  Misses         1174     1174              
  Partials        264      264              
Impacted Files Coverage Δ Complexity Δ
.../io/sentry/spring/SentryInitBeanPostProcessor.java 93.75% <100.00%> (+1.44%) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e98134...d8fe77b. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
missing changelog, as if a user did it manually, now it's done automatically.

@maciejwalkowiak maciejwalkowiak merged commit 2fb7023 into main Jan 18, 2021
@maciejwalkowiak maciejwalkowiak deleted the spring-detect-traces-sampler branch January 18, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants