Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Free Local Refs manually due to Android local ref. count limits #1179

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 18, 2021

📜 Description

Fix: Free Local Refs manually due to Android local ref. count limits

💡 Motivation and Context

Fix getsentry/sentry-dart#267

💚 How did you test it?

Running on Android 7 arm64

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Release a patch to 3.2.0

@marandaneto marandaneto changed the title link Fix: Free Local Refs manually due to Android local ref. count limits Jan 18, 2021
@marandaneto marandaneto requested review from a team and Swatinem January 18, 2021 10:52
@marandaneto
Copy link
Contributor Author

@bruno-garcia should we patch 3.2.x and bump on Flutter?

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Til

@bruno-garcia
Copy link
Member

A patch release on 2.x sounds like a very good idea. Good call

@marandaneto marandaneto merged commit bba0c16 into main Jan 18, 2021
@marandaneto marandaneto deleted the fix/android-mem-limit branch January 18, 2021 14:18
marandaneto added a commit that referenced this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Crash] tgkill crash reported on Play Console
3 participants