Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass request to CustomSamplingContext in Spring integration. #1172

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Pass complete HttpServletRequest to CustomSamplingContext in Spring integration.

💡 Motivation and Context

Fixes #1168

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #1172 (6e55daf) into main (931464f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1172   +/-   ##
=========================================
  Coverage     75.25%   75.26%           
  Complexity     1662     1662           
=========================================
  Files           173      173           
  Lines          5812     5813    +1     
  Branches        568      569    +1     
=========================================
+ Hits           4374     4375    +1     
  Misses         1174     1174           
  Partials        264      264           
Impacted Files Coverage Δ Complexity Δ
.../io/sentry/spring/tracing/SentryTracingFilter.java 84.84% <100.00%> (+0.47%) 4.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931464f...6e55daf. Read the comment docs.

@bruno-garcia
Copy link
Member

           > Connect to dl.google.com:443 [dl.google.com/172.217.15.78, dl.google.com/2607:f8b0:4004:800:0:0:0:200e] failed: No route to host (connect failed)

Transient error

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruno-garcia bruno-garcia merged commit b3d4178 into main Jan 15, 2021
@bruno-garcia bruno-garcia deleted the gh-1168 branch January 15, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spring SentryTracingFilter does not provide a CustomSamplingContext
4 participants