-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize Logback after context refreshes. #1129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1129 +/- ##
============================================
+ Coverage 74.34% 75.21% +0.86%
- Complexity 1592 1603 +11
============================================
Files 163 165 +2
Lines 5617 5567 -50
Branches 574 547 -27
============================================
+ Hits 4176 4187 +11
+ Misses 1164 1128 -36
+ Partials 277 252 -25
Continue to review full report at Codecov.
|
sentry-spring-boot-starter/src/main/java/io/sentry/spring/boot/SentryLogbackInitializer.java
Outdated
Show resolved
Hide resolved
sentry-spring-boot-starter/src/main/java/io/sentry/spring/boot/SentryLogbackInitializer.java
Outdated
Show resolved
Hide resolved
should we add a changelog? if it fixes a bug, I'd say it's worth it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Spring Context can be refreshed while application is running (for example using Spring Cloud Bus). Without this change,
SentryAppender
would not get registered once refresh happens.💡 Motivation and Context
#1128
💚 How did you test it?
AFAIK It is not possible to trigger context refresh in Spring integration testing framework.
📝 Checklist