-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not return null from startTransaction. #1126
Conversation
As requested - extracted |
Codecov Report
@@ Coverage Diff @@
## main #1126 +/- ##
============================================
- Coverage 75.20% 74.93% -0.27%
- Complexity 1599 1606 +7
============================================
Files 164 165 +1
Lines 5561 5593 +32
Branches 546 547 +1
============================================
+ Hits 4182 4191 +9
- Misses 1128 1150 +22
- Partials 251 252 +1
Continue to review full report at Codecov.
|
In this case I think we can ignore @codecov-io. I can artificially bump the coverage but I don't see the point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Changes
startTransaction
method to never returnnull
.💡 Motivation and Context
null
could have been returned only if hub is closed or if stack contains zero items.captureTransaction
does the check for closed hub anywaysstack
contains zero items💚 How did you test it?
Tests already cover it.
📝 Checklist
🔮 Next steps
Create abstraction over stack to make sure that stack can never be empty.