Add the ability to register multiple OptionsConfiguration beans. #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
approved these changes
Dec 3, 2020
bruno-garcia
approved these changes
Dec 4, 2020
| @@ -10,6 +10,7 @@ | |||
| * Enhancement: Resolve in-app-includes and in-app-excludes parameters from the external configuration | |||
| * Enhancement: Make InAppIncludesResolver public (#1084) | |||
| * Ref: Change "op" to "operation" in @SentrySpan and @SentryTransaction | |||
| * Enhancement: Add the ability to register multiple OptionsConfiguration beans (#1093) | |||
There was a problem hiding this comment.
L: can we just call it feat: like in the other repos at Sentry?
Enhancement takes up a lot of space of the changelog
There was a problem hiding this comment.
Feature is something different than enhancement AFAIK. Perhaps "enc"?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Followup to #1084. Makes it possible to register multiple
OptionsConfiguration.Additionally, makes
InAppIncludesResolver#resolveInAppIncludesso that it can be used in custom auto-configurations by users.💡 Motivation and Context
Issue #1080.
Currently when creating custom
OptionsConfigurationbean, users have to either opt-out from the default behavior or replicate it even when they need just to set single custom property.💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps