Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Append DebugImage list if the Event already has it #1092

Merged
merged 4 commits into from
Dec 3, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Dec 3, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fix: Append DebugImage list if the Event already has it

💡 Motivation and Context

Events that contain an ImageList should append the Proguard debug image instead of skipping it.
This is a fix for Flutter mainly, as we do have an ImageList but we still want to deobfuscate Java/Kotlin stack traces

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Bump SDK on Flutter

@codecov-io
Copy link

codecov-io commented Dec 3, 2020

Codecov Report

Merging #1092 (ecc2b7b) into main (e7b8b6c) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1092      +/-   ##
============================================
+ Coverage     73.61%   73.66%   +0.04%     
- Complexity     1550     1551       +1     
============================================
  Files           162      162              
  Lines          5523     5532       +9     
  Branches        562      562              
============================================
+ Hits           4066     4075       +9     
  Misses         1171     1171              
  Partials        286      286              
Impacted Files Coverage Δ Complexity Δ
sentry/src/main/java/io/sentry/DateUtils.java 87.87% <0.00%> (+4.54%) 9.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b8b6c...ecc2b7b. Read the comment docs.

@marandaneto marandaneto merged commit 32e8d30 into main Dec 3, 2020
@marandaneto marandaneto deleted the fix/append-debug-images branch December 3, 2020 15:24
marandaneto added a commit that referenced this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants