Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use neutral Locale for String operations #1033

Merged
merged 2 commits into from
Nov 12, 2020
Merged

fix: use neutral Locale for String operations #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aa90e7
fix: use neutral Locale for String operations
marandaneto Nov 9, 2020
8988a94
fix
marandaneto Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Increase max cached events to 30 (#1029)
* Normalize DSN URI (#1030)
* fix: use neutral Locale for String operations #1033

# 3.1.2

Expand Down
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/Breadcrumb.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public Breadcrumb(final @Nullable Date timestamp) {
breadcrumb.setType("http");
breadcrumb.setCategory("http");
breadcrumb.setData("url", url);
breadcrumb.setData("method", method.toUpperCase(Locale.getDefault()));
breadcrumb.setData("method", method.toUpperCase(Locale.ROOT));
return breadcrumb;
}

Expand Down
3 changes: 1 addition & 2 deletions sentry/src/main/java/io/sentry/config/EnvironmentVariablePropertiesProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ final class EnvironmentVariablePropertiesProvider implements PropertiesProvider
@Override
public @Nullable String getProperty(@NotNull String property) {
return StringUtils.removeSurrounding(
System.getenv(PREFIX + "_" + property.replace(".", "_").toUpperCase(Locale.getDefault())),
"\"");
System.getenv(PREFIX + "_" + property.replace(".", "_").toUpperCase(Locale.ROOT)), "\"");
}
}