Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize DSN URI. #1032

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Normalize DSN URI. #1032

merged 3 commits into from
Nov 5, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Normalizes DSN URI.

💡 Motivation and Context

#1030

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this also could be an issue on the sentry server, right? the URL should be normalized there also before shown on the UI

@maciejwalkowiak
Copy link
Contributor Author

Yes I believe it should be fixed on the UI side too.

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #1032 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1032   +/-   ##
=========================================
  Coverage     71.98%   71.98%           
  Complexity     1321     1321           
=========================================
  Files           135      135           
  Lines          4816     4816           
  Branches        492      492           
=========================================
  Hits           3467     3467           
  Misses         1091     1091           
  Partials        258      258           
Impacted Files Coverage Δ Complexity Δ
sentry/src/main/java/io/sentry/Dsn.java 94.11% <100.00%> (ø) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c954e9...12b8e5b. Read the comment docs.

@bruno-garcia bruno-garcia merged commit 00a3b85 into main Nov 5, 2020
@bruno-garcia bruno-garcia deleted the gh-1030 branch November 5, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants