Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max queue items to 30 #1029

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Max queue items to 30 #1029

merged 2 commits into from
Nov 4, 2020

Conversation

bruno-garcia
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #1029 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1029   +/-   ##
=========================================
  Coverage     71.98%   71.98%           
  Complexity     1321     1321           
=========================================
  Files           135      135           
  Lines          4816     4816           
  Branches        492      492           
=========================================
  Hits           3467     3467           
  Misses         1091     1091           
  Partials        258      258           
Impacted Files Coverage Δ Complexity Δ
sentry/src/main/java/io/sentry/SentryOptions.java 81.77% <100.00%> (ø) 90.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97683e3...0bd7e25. Read the comment docs.

Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the context of this change?

@marandaneto
Copy link
Contributor

What is the context of this change?

30 is the default value for the transport queuing across the SDKs, this one was off.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruno-garcia bruno-garcia merged commit 3c954e9 into main Nov 4, 2020
@bruno-garcia bruno-garcia deleted the ref/max-items-30 branch November 4, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants