Transactions/Spans finished without status or associated error

[marandaneto]

SentrySpanAdvice and SentryOkHttpInterceptor do finish a span either with SpanStatus.OK or SpanStatus.INTERNAL_ERROR (or depending on HTTP response code), also associates the error to the span if any.

SentrySpanClientHttpRequestInterceptor does not set an status if execution.execute throws nor associates the error.

SentryTracingFilter does not associate the error if any.

SentryTransactionAdvice does not set a status if invocation.proceed throws nor associates the error.

[marandaneto]

@maciejwalkowiak let me know if it was designed like this or just an oversight.

[maciejwalkowiak]

SentrySpanClientHttpRequestInterceptor - execution.execute does not throw when HTTP status != 2xx, but indeed IOException could happen so we should handle this.

SentryTracingFilter - since exception happens within the scope of transaction it gets associated with the trace in SentryClient.

SentryTransactionAdvice - you're right, will fix it.

[marandaneto]

@Tyrrrz please also double-check that on .NET we do cover those cases, we need to finish the span with status either successfully or not, even associating its error whenever possible.

[marandaneto]

Requires #1421

[marandaneto]

@maciejwalkowiak can I close this? I guess every change has been tackled right

[maciejwalkowiak]

Yep