Apply suggestions from code review

Co-authored-by: Roman Zavarnitsyn <[email protected]>
getsentry · Feb 9, 2023 · 78c7345 · 78c7345
1 parent 17500bd
commit 78c7345
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,7 @@
 
 ### Features
 
-- Add capabilities to track compose composition/rendering time ([#2507](https://github.com/getsentry/sentry-java/pull/2507))
+- Add capabilities to track Jetpack Compose composition/rendering time ([#2507](https://github.com/getsentry/sentry-java/pull/2507))
 
 ### Fixes
 

diff --git a/sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryComposeTracing.kt b/sentry-compose/src/androidMain/kotlin/io/sentry/compose/SentryComposeTracing.kt
@@ -13,11 +13,11 @@ import androidx.compose.ui.platform.testTag
 import io.sentry.Sentry
 import io.sentry.SpanOptions
 
-private const val OP_PARENT_COMPOSITION = "compose.composition"
-private const val OP_COMPOSE = "compose"
+private const val OP_PARENT_COMPOSITION = "ui.compose.composition"
+private const val OP_COMPOSE = "ui.compose"
 
-private const val OP_PARENT_RENDER = "compose.rendering"
-private const val OP_RENDER = "render"
+private const val OP_PARENT_RENDER = "ui.compose.rendering"
+private const val OP_RENDER = "ui.render"
 
 @Immutable
 private class ImmutableHolder<T>(var item: T)

diff --git a/...sentry-samples-android/src/main/java/io/sentry/samples/android/compose/ComposeActivity.kt b/...sentry-samples-android/src/main/java/io/sentry/samples/android/compose/ComposeActivity.kt
@@ -41,7 +41,7 @@ class ComposeActivity : ComponentActivity() {
         super.onCreate(savedInstanceState)
 
         setContent {
-            val navController = rememberNavController()
+            val navController = rememberNavController().withSentryObservableEffect()
             SampleNavigation(navController)
         }
     }