ref: remove Span.isTransaction attribute #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greywolve
commented
Oct 17, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know! |
greywolve
commented
Oct 17, 2023
cleptric
reviewed
Oct 23, 2023
Instead we rely on a new implementation of IsTransaction() that checks if the root of the span recorder is equal to the span itself.
greywolve
force-pushed
the
remove_is_transaction_attribute
branch
from
52aa0c0 to
26531df
Compare
|
@cleptric fixed up. :) |
cleptric
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we rely on a new implementation of IsTransaction() that checks if the span's parent is nil.
Fixes #581