Skip to content

Commit

Permalink
+ versions don't work sadface (#3)
Browse files Browse the repository at this point in the history
* + versions don't work sadface

* Update bump-version.sh

* use post versions
  • Loading branch information
asottile-sentry authored Oct 31, 2023
1 parent d635dc9 commit 5f0428b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ git checkout 1.2.3 -b sentry-1.2.3
- cherry-pick relevant commit(s) from previous releases

releases are done through craft in the release.yml workflow -- make sure to
target your particular branch with a `+sentry#` release postfix
target your particular branch with a `-#` release postfix (like `1.2.3-1`)

___

Expand Down
5 changes: 3 additions & 2 deletions scripts/bump-version.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#!/usr/bin/env bash
set -euxo pipefail

if ! grep -E '^.*\+sentry[0-9]+' <<< "$2"; then
: "version must be D.D.D+sentryD got: $2"
if ! grep -E '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$' <<< "$2"; then
: "expected #.#.#-# got $2"
exit 1
fi

sed -i "s/^ version="'"'".*"'"'",$/ version="'"'"$2"'"'",/" setup.py

0 comments on commit 5f0428b

Please sign in to comment.