cherry-pick upstream: fix function overload of Library.simple_tag (#26)

Co-authored-by: Anthony Sottile <[email protected]>
getsentry · Oct 4, 2024 · 57bdf0f · 57bdf0f
1 parent bfcb743
commit 57bdf0f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/django-stubs/template/library.pyi b/django-stubs/template/library.pyi
@@ -29,7 +29,7 @@ class Library:
     @overload
     def filter(self, name: str | None = None, filter_func: None = None, **flags: Any) -> Callable[[_C], _C]: ...
     @overload
-    def simple_tag(self, func: _C) -> _C: ...
+    def simple_tag(self, func: _C, takes_context: bool | None = None, name: str | None = None) -> _C: ...
     @overload
     def simple_tag(self, takes_context: bool | None = None, name: str | None = None) -> Callable[[_C], _C]: ...
     def inclusion_tag(

diff --git a/tests/typecheck/template/test_library.yml b/tests/typecheck/template/test_library.yml
@@ -57,6 +57,16 @@
 
         reveal_type(some_function) # N: Revealed type is "def (value: builtins.int) -> builtins.int"
 
+-   case: register_simple_tag_via_call
+    main: |
+        from django import template
+        register = template.Library()
+
+        def f(s: str) -> str:
+            return s * 2
+
+        reveal_type(register.simple_tag(f, name='double')) # N: Revealed type is "def (s: builtins.str) -> builtins.str"
+
 -   case: register_tag_no_args
     main: |
         from django import template