Accept structs as structured logs in Sentry.LoggerHandler #780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
While testing my custom logger handler, which is based on the Sentry Elixir handler, I encountered an issue where passing a struct to
Logger.error
causes the handler to detach. The error handler only supports keywords and maps.The problem arose when using the Tesla library, which passes a
Tesla.Env
struct toLogger.error
. Interestingly,Logger.info
does support passing structs, and the struct is displayed as a keyword list or map with the__struct__
fieldI added a test that reproduce the issue and a fix proposition.