New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example configuration on Sentry.Sources #543

Merged

whatyouhide merged 1 commit into getsentry:master from scudelletti:ds-fix-source-docs

Jul 11, 2023

Contributor

scudelletti commented May 31, 2023 •

edited

Loading

Hello there, this PR aims to fix and improve the example on Sentry.Sources.

If I understood correctly:

root_source_code_path is deprecated and expects a single path
root_source_code_paths expects a list of paths.

Based on that there are 2 issues:

The example sets root_source_code_path with a list of paths. That seems an incorrect value.
root_source_code_paths should be preferred over the deprecated root_source_code_path config.

Thanks for your time.


          Fix example configuration

bb5f078

whatyouhide approved these changes

View reviewed changes

whatyouhide merged commit 46b1a18 into getsentry:master

Collaborator

whatyouhide commented Jul 11, 2023

Thank you @scudelletti! 💟

scudelletti deleted the ds-fix-source-docs branch

July 11, 2023 08:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet