Add additional data to transactions #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bruno-garcia I made it so it applies scope and adds environment and release. Is that good/sufficient? |
bruno-garcia
approved these changes
Jan 26, 2021
| @@ -18,6 +18,12 @@ public interface ITransaction : ISpan, ITransactionContext, IEventLike | |||
| // 'new' because it adds a setter | |||
| new string Name { get; set; } | |||
|
|
|||
| // Should this be on IEventLike? | |||
There was a problem hiding this comment.
Yeah we should bump this so it's available on any Event (transaction or errors)
There was a problem hiding this comment.
The problem is currently IEventLike also encompasses Scope, which does not have Release :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #762