ref: Handle non json error response messages. #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 76.01% 77.96% +1.94%
==========================================
Files 163 163
Lines 5250 5260 +10
Branches 1350 1354 +4
==========================================
+ Hits 3991 4101 +110
+ Misses 879 769 -110
- Partials 380 390 +10
Continue to review full report at Codecov.
|
| @@ -68,17 +68,36 @@ internal static class DiagnosticLoggerExtensions | |||
| public static void LogError<TArg>( | |||
| this IDiagnosticLogger logger, | |||
| string message, | |||
| Exception exception, | |||
| Exception? exception, | |||
There was a problem hiding this comment.
Not supposed to be nullable.
We should have an overload that doesn't take it then
|
|
||
| _options.DiagnosticLogger?.LogError( | ||
| "Sentry rejected the envelope {0}. Status code: {1}. Error detail: {2}. Error causes: {3}.", | ||
| null, |
There was a problem hiding this comment.
Lets have an overload that doesn't take null
|
LogError Extensions are going to be implemented on another PR. For now, I'm using the old Log pattern. |
bruno-garcia
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #689.
Closes #688