Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better Mono stacktraces #578

Merged
merged 4 commits into from
Nov 8, 2020
Merged

feat: Better Mono stacktraces #578

merged 4 commits into from
Nov 8, 2020

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Nov 7, 2020

/cc @lucas-zimerman

As dad says: Let's rip off the bandaid.

Get some better Mono support for Unity (and Xamarin if that lives)

@bruno-garcia bruno-garcia requested a review from Tyrrrz November 7, 2020 05:23
@codecov-io
Copy link

codecov-io commented Nov 7, 2020

Codecov Report

Merging #578 (5f5c614) into main (db6d590) will increase coverage by 0.44%.
The diff coverage is 83.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
+ Coverage   63.04%   63.48%   +0.44%     
==========================================
  Files         179      181       +2     
  Lines        5019     5130     +111     
  Branches      861      879      +18     
==========================================
+ Hits         3164     3257      +93     
- Misses       1627     1637      +10     
- Partials      228      236       +8     
Impacted Files Coverage Δ
...rc/Sentry/Extensibility/SentryStackTraceFactory.cs 87.67% <ø> (ø)
src/Sentry/Protocol/Exceptions/SentryStackFrame.cs 100.00% <ø> (ø)
src/Sentry/Internal/StackFrameData.cs 77.14% <77.14%> (ø)
src/Sentry/Internal/MonoSentryStackTraceFactory.cs 94.59% <94.59%> (ø)
src/Sentry/SentryOptions.cs 93.33% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6d590...6461be9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants