Framework and runtime info #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed unused nuget function
* Removed unused nuget function
Build on Linux and macOS - run on travis
* Runtime has FrameworkInstallation when compiled to NETFX * Sample app outputs calls in different targets * Run sample on Mono * Execute flag on run.sh * Add sample output to Console readme
…r FrameworkInfo on netstandard targets.
feat: Mappings for .NET Framework 4.8
ref: project improvements
.NET Framework 4.8 patches
release: 1.1.1
bruno-garcia
commented
Sep 24, 2020
bruno-garcia
commented
Sep 24, 2020
bruno-garcia
commented
Sep 24, 2020
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
===========================================
+ Coverage 60.30% 86.01% +25.71%
===========================================
Files 112 126 +14
Lines 2660 3168 +508
Branches 601 726 +125
===========================================
+ Hits 1604 2725 +1121
+ Misses 875 249 -626
- Partials 181 194 +13
Continue to review full report at Codecov.
|
Tyrrrz
reviewed
Sep 24, 2020
Comment on lines
46
to
79
| FrameworkInstallation latest = null; | ||
| foreach (var installation in GetInstallations()) | ||
| { | ||
| if (latest == null) | ||
| { | ||
| latest = installation; | ||
| } | ||
|
|
||
| if (clrVersion == 2) | ||
| { | ||
| // CLR 2 runs .NET 2 to 3.5 | ||
| if ((installation.Version.Major == 2 || installation.Version.Major == 3) | ||
| && installation.Version >= latest.Version) | ||
| { | ||
| latest = installation; | ||
| } | ||
| else | ||
| { | ||
| break; | ||
| } | ||
| } | ||
| else if (clrVersion == 4) | ||
| { | ||
| if (installation.Version.Major == 4 | ||
| && installation.Version >= latest.Version) | ||
| { | ||
| latest = installation; | ||
| } | ||
| else | ||
| { | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this loop be replaced with latest = installations.OrderBy(...).FirstOrDefault() to avoid mutations and to make it simpler?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.