Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NRTs to Sentry.AspNetCore #520

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Add NRTs to Sentry.AspNetCore #520

merged 2 commits into from
Sep 22, 2020

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Sep 21, 2020

No description provided.

@Tyrrrz Tyrrrz added Feature New feature or request Framework: ASP.NET Core labels Sep 21, 2020
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 21, 2020

There were a few guards here and there that were checking that injected objects were not null. I don't think you can inject a null in default AspNetCore DI container. Generally speaking, they still might make sense, but not sure if enough to keep them. Thoughts?

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Sep 21, 2020

@bruno-garcia looks like there are tests that pass nulls into an internal class constructor. Should we remove those?

@bruno-garcia
Copy link
Member

@bruno-garcia looks like there are tests that pass nulls into an internal class constructor. Should we remove those?

Yeah all the internal stuff we can guarantee will combile with C# 8 so feel free to delete all of those.

Guards in classes ctor I wouldn't touch if they are there. If they are instantiated via DI in ASP.NET Core they'd get an instance otherwise will fail to resolve but that assumes they'll only be resolved via DI and not used in a different way

@Tyrrrz Tyrrrz force-pushed the feature/nrt-aspnetcore branch from 3a0e112 to 21608a7 Compare September 22, 2020 12:56
@Tyrrrz Tyrrrz force-pushed the feature/nrt-aspnetcore branch from 21608a7 to 49a209b Compare September 22, 2020 14:11
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ ✨ ✨

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, no need to optimzie for not having those. We just make sure they are there

@Tyrrrz Tyrrrz merged commit 6bfba6b into main Sep 22, 2020
@Tyrrrz Tyrrrz deleted the feature/nrt-aspnetcore branch September 22, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants