-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental EnableAppHangTrackingV2 configuration flag to the dotnet SDK #3877
Add experimental EnableAppHangTrackingV2 configuration flag to the dotnet SDK #3877
Conversation
…tnet SDK
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3877 +/- ##
==========================================
+ Coverage 75.73% 76.50% +0.76%
==========================================
Files 357 389 +32
Lines 13466 14226 +760
Branches 2671 2860 +189
==========================================
+ Hits 10198 10883 +685
- Misses 2593 2649 +56
- Partials 675 694 +19 ☔ View full report in Codecov by Sentry. |
Thanks for the PR @thisisthekap - much appreciated! fyi: there's an issue with our CI builds when running on PRs from forks of the repo: As a workaround, I think you should be able to run these steps manually to format the code and commit the resulting changes: sentry-dotnet/.github/workflows/format-code.yml Lines 34 to 43 in 14bdac4
The only other thing that's missing is an entry in the changelog. For that, you need to add an entry to the "Unreleased" section in Example: ## Unreleased
- Add experimental EnableAppHangTrackingV2 configuration flag to the dotnet SDK ([#3877](https://github.com/getsentry/sentry-dotnet/pull/3877)) |
Hi @jamescrosswell, thank you for your feedback! All requested changes should be done. |
Thank you @thisisthekap ! |
Fixes #3876