Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental EnableAppHangTrackingV2 configuration flag to the dotnet SDK #3877

Conversation

thisisthekap
Copy link
Contributor

Fixes #3876

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.50%. Comparing base (495e742) to head (e6e3eef).
Report is 432 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3877      +/-   ##
==========================================
+ Coverage   75.73%   76.50%   +0.76%     
==========================================
  Files         357      389      +32     
  Lines       13466    14226     +760     
  Branches     2671     2860     +189     
==========================================
+ Hits        10198    10883     +685     
- Misses       2593     2649      +56     
- Partials      675      694      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescrosswell
Copy link
Collaborator

Thanks for the PR @thisisthekap - much appreciated!

fyi: there's an issue with our CI builds when running on PRs from forks of the repo:

As a workaround, I think you should be able to run these steps manually to format the code and commit the resulting changes:

- name: Format Code
# We're excluding `./**/*OptionsSetup.cs` from the format because the tool struggles with
# source generators
run: dotnet format Sentry.sln --no-restore --exclude ./modules --exclude ./**/*OptionsSetup.cs
# actions/checkout fetches only a single commit in a detached HEAD state. Therefore
# we need to pass the current branch, otherwise we can't commit the changes.
# GITHUB_HEAD_REF is the name of the head branch. GitHub Actions only sets this for PRs.
- name: Commit Formatted Code
run: ./scripts/commit-formatted-code.sh $GITHUB_HEAD_REF

The only other thing that's missing is an entry in the changelog. For that, you need to add an entry to the "Unreleased" section in CHANGELOG.md.

Example:

## Unreleased

- Add experimental EnableAppHangTrackingV2 configuration flag to the dotnet SDK ([#3877](https://github.com/getsentry/sentry-dotnet/pull/3877))

@thisisthekap
Copy link
Contributor Author

Hi @jamescrosswell, thank you for your feedback!

All requested changes should be done.

CHANGELOG.md Outdated Show resolved Hide resolved
src/Sentry/Platforms/Cocoa/SentryOptions.cs Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia merged commit c20d162 into getsentry:main Jan 9, 2025
22 checks passed
@bruno-garcia
Copy link
Member

Thank you @thisisthekap !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnableAppHangTrackingV2 not exposed through dotnet SDK
3 participants