Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MAUI samples config - enable iOS/MAC deployment and debug for Windows #3695

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

bricefriha
Copy link
Collaborator

As mentioned on Discord, I think it would be handy to allow Windows machines to deploy the iOS sample app using a paired Mac for testing purposes.

Resources

in case you need some guidance to Pair a Mac to your Windows PC, Microsoft has some excellent documentation for this

#skip-changelog

@bricefriha bricefriha marked this pull request as draft October 20, 2024 11:45
@bricefriha bricefriha changed the title fix: MAUI samples config - enable iOS/MAC deployment and debug fix: MAUI samples config - enable iOS/MAC deployment and debug for Windows Oct 20, 2024
@jamescrosswell
Copy link
Collaborator

@bricefriha would this then require people using the solution on Windows to have a paired Mac? We probably wouldn't want to do that as it would limit the number of people who could contribute to the repo... so it'd be good to "allow" people to work on Windows with a paired Mac but not "require" a paired Mac when working on Windows.

@bricefriha
Copy link
Collaborator Author

bricefriha commented Oct 20, 2024

so it'd be good to "allow" people to work on Windows with a paired Mac but not "require" a paired Mac when working on Windows

sorry for the confusion, you are not required to pair it to a mac with this config. The changes allows people to pair a mac but they don't have to.

e.g: I have a project with a similar configuration and I was able to work on it while in Germany away from my Mac

@bricefriha bricefriha marked this pull request as ready for review October 21, 2024 08:42
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruno-garcia
Copy link
Member

Thanks. @jamescrosswell unless this breaks your workflow somehow, otherwise please merge

@jamescrosswell jamescrosswell merged commit ed63749 into main Oct 21, 2024
23 checks passed
@jamescrosswell jamescrosswell deleted the fix/enable_windows_ios_simulator branch October 21, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants