-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Android - make sure logcat.log is attached to unhandled event (SIGSEGV Segfault) #3694
Conversation
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>
…oid.Init(AppContext, configuration);`
…coped namespace declaration
See comment: |
@bruno-garcia @jamescrosswell I created a repo to test this alpha release and it works perfectly https://github.com/bricefriha/Sentry-3694 |
Awesome! thank you for that. |
We could, but the issue is that we need to use the Android SDK version 7.15.0-alpha.1 until the NDKHandler setting is available on the full release. So shouldn't we wait for that first? |
If it's validated, we should reach out to folks on Android to merge that to We can merge ours (after bumping to that version) then. Also: Should that option be the new default? So users don't need to do anything? |
sounds good
yes it is, so basically users don't need to change anything at all |
What's the next steps for this? |
I let the Java team know that we are ready to merge so they are working on merging their PRs as well once they have the update on the main release, we can merge |
merged! getsentry/sentry-native#1027 (comment) We'd like to wait for their release though, so we can checkout the release tag instead of a random commit sha |
The release is out now! We just need an update from |
@markushi any timeframe on getting the fix we tested in 7.15.0-alpha.1 into an official release? I'd love to roll this out in the .NET SDK but we've got a bit of a dependency chain. Looks like we'll have to do something similar for iOS as well, and it would be nice to reference this solution when discussing with the cocoa team. |
If it's tested and we know the change works, we can merge and get this released at any time. Let me get the PR up-to-date first. |
Looks like the fix was included with the 7.19.0 release of the Java SDK. We just need to bump the version in this PR and we should be good to go! |
From sentry-native#1027, we had to add the handler strategy to the .NET SDK, from the sentry-java (7.15.0-alpha1).
This is also meant to fix #3461. I tested this, and it seems to be fixed now.
More context at: