Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android - make sure logcat.log is attached to unhandled event (SIGSEGV Segfault) #3694

Merged
merged 46 commits into from
Dec 18, 2024

Conversation

bricefriha
Copy link
Contributor

@bricefriha bricefriha commented Oct 18, 2024

From sentry-native#1027, we had to add the handler strategy to the .NET SDK, from the sentry-java (7.15.0-alpha1).

This is also meant to fix #3461. I tested this, and it seems to be fixed now.

More context at:

@bricefriha bricefriha changed the title Android - add handler strategy Android - implement handler strategy Oct 18, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj Outdated Show resolved Hide resolved
src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj Outdated Show resolved Hide resolved
src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj Outdated Show resolved Hide resolved
src/Sentry/NdkHandlerStrategy.cs Outdated Show resolved Hide resolved
src/Sentry/SentryOptions.cs Outdated Show resolved Hide resolved
test/Sentry.Maui.Tests/SentryMauiOptionsTests.cs Outdated Show resolved Hide resolved
src/Sentry/Platforms/Android/SentrySdk.cs Outdated Show resolved Hide resolved
src/Sentry/Platforms/Android/SentrySdk.cs Outdated Show resolved Hide resolved
src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj Outdated Show resolved Hide resolved
src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj Outdated Show resolved Hide resolved
src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj Outdated Show resolved Hide resolved
src/Sentry/NdkHandlerStrategy.cs Outdated Show resolved Hide resolved
src/Sentry/Platforms/Android/SentrySdk.cs Outdated Show resolved Hide resolved
src/Sentry/Platforms/Android/SentrySdk.cs Outdated Show resolved Hide resolved
src/Sentry/Platforms/Android/SentrySdk.cs Outdated Show resolved Hide resolved
@jamescrosswell
Copy link
Collaborator

which issue to reach out for feedback? anyone trying this out to help validate?

See comment:

@bricefriha
Copy link
Contributor Author

anyone trying this out to help validate?

@bruno-garcia @jamescrosswell I created a repo to test this alpha release and it works perfectly https://github.com/bricefriha/Sentry-3694

@bruno-garcia
Copy link
Member

anyone trying this out to help validate?

@bruno-garcia @jamescrosswell I created a repo to test this alpha release and it works perfectly bricefriha/Sentry-3694

Awesome! thank you for that.
Shoudl we merge?

@bricefriha
Copy link
Contributor Author

Shoudl we merge?

We could, but the issue is that we need to use the Android SDK version 7.15.0-alpha.1 until the NDKHandler setting is available on the full release. So shouldn't we wait for that first?

@bruno-garcia
Copy link
Member

Shoudl we merge?

We could, but the issue is that we need to use the Android SDK version 7.15.0-alpha.1 until the NDKHandler setting is available on the full release. So shouldn't we wait for that first?

If it's validated, we should reach out to folks on Android to merge that to main and ship a new release.

We can merge ours (after bumping to that version) then.

Also: Should that option be the new default? So users don't need to do anything?

@bricefriha
Copy link
Contributor Author

We can merge ours (after bumping to that version) then.

sounds good

Should that option be the new default? So users don't need to do anything?

yes it is, so basically users don't need to change anything at all

@bruno-garcia
Copy link
Member

What's the next steps for this?

@bricefriha
Copy link
Contributor Author

What's the next steps for this?

I let the Java team know that we are ready to merge so they are working on merging their PRs as well

once they have the update on the main release, we can merge

@bruno-garcia
Copy link
Member

merged! getsentry/sentry-native#1027 (comment)

We'd like to wait for their release though, so we can checkout the release tag instead of a random commit sha

@bricefriha
Copy link
Contributor Author

We'd like to wait for their release though

The release is out now!
https://github.com/getsentry/sentry-native/releases/tag/0.7.13

We just need an update from sentry-java

@jamescrosswell
Copy link
Collaborator

The release is out now! https://github.com/getsentry/sentry-native/releases/tag/0.7.13

We just need an update from sentry-java

@markushi any timeframe on getting the fix we tested in 7.15.0-alpha.1 into an official release? I'd love to roll this out in the .NET SDK but we've got a bit of a dependency chain.

Looks like we'll have to do something similar for iOS as well, and it would be nice to reference this solution when discussing with the cocoa team.

@markushi
Copy link
Member

markushi commented Dec 5, 2024

The release is out now! getsentry/sentry-native@0.7.13 (release)
We just need an update from sentry-java

@markushi any timeframe on getting the fix we tested in 7.15.0-alpha.1 into an official release? I'd love to roll this out in the .NET SDK but we've got a bit of a dependency chain.

Looks like we'll have to do something similar for iOS as well, and it would be nice to reference this solution when discussing with the cocoa team.

If it's tested and we know the change works, we can merge and get this released at any time. Let me get the PR up-to-date first.

@jamescrosswell
Copy link
Collaborator

Looks like the fix was included with the 7.19.0 release of the Java SDK. We just need to bump the version in this PR and we should be good to go!

@jamescrosswell jamescrosswell self-requested a review December 17, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logcat.log is not attached to unhandled event (SIGSEGV Segfault)
5 participants