Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unobsoleted SentryClient.Dispose #2842

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

bitsandfoxes
Copy link
Contributor

Originally, this came up from #599 and #1354

But based on #321 (comment) this should no longer be an issue.

@bitsandfoxes bitsandfoxes changed the title Unobsoleted SentryClientDispose Unobsoleted SentryClient.Dispose Nov 15, 2023
Copy link
Contributor

github-actions bot commented Nov 15, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Unobsoleted `SentryClient.Dispose` ([#2842](https://github.com/getsentry/sentry-dotnet/pull/2842))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 7d1d1d0

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog missing

@vaind vaind merged commit 34b8f9c into feat/4.0.0 Nov 17, 2023
6 of 7 checks passed
@vaind vaind deleted the feat/client-dispose-obsolete branch November 17, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants