fix: don't add WinUI integration on mobile #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this should be OK. Technically you can target WinUI 3 from a .NET MAUI app - I'm not sure what the value of __MOBILE__ will hold in that case. It doesn't sound, logically, like a mobile app but possibly worth double checking.
There was a problem hiding this comment.
I've tried running the MAUI sample on Widnows but it doesn't seem to work for me.
Docs say MOBILE is defined for iOS and Android
jamescrosswell
approved these changes
Nov 13, 2023
vaind
force-pushed
the
fix/winui-platform-specific
branch
from
8bb2d95 to
43576ab
Compare
vaind
force-pushed
the
fix/winui-platform-specific
branch
from
43576ab to
f1ccafb
Compare
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- don't add WinUI integration on mobile ([#2821](https://github.com/getsentry/sentry-dotnet/pull/2821))If none of the above apply, you can opt out of this check by adding |
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed we do this when testing NativeAOT on iOS