Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NativeAOT iOS support #2820

Merged
merged 8 commits into from
Nov 16, 2023
Merged

feat: NativeAOT iOS support #2820

merged 8 commits into from
Nov 16, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Nov 11, 2023 •
edited
Loading

Adds support for NativeAOT for .net8-ios (vanilla & MAUI)

closes #2180

#skip-changelog

@vaind vaind mentioned this pull request Nov 11, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2023 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2749094

@tipa
Copy link

tipa commented Nov 16, 2023

Will this also make NativeAOT on macOS work (non-MAUI)? Or should it already work?

@vaind
Copy link
Collaborator Author

vaind commented Nov 16, 2023

Will this also make NativeAOT on macOS work (non-MAUI)? Or should it already work?

That's already available in v4.0.0 alpha

@tipa
Copy link

tipa commented Nov 16, 2023

For both iOS and macOS? I wasn't able to capture crashes in my NativeAOT iOS app using v4.0.0 alpha

@vaind
Copy link
Collaborator Author

vaind commented Nov 16, 2023

For both iOS and macOS? I wasn't able to capture crashes in my NativeAOT iOS app using v4.0.0 alpha

No, you've asked about macOS so I've answered for macOS. That is already available.

@vaind
Copy link
Collaborator Author

vaind commented Nov 16, 2023 •
edited
Loading

I wasn't able to capture crashes

Also, I've just noticed this bit -> We're currently not handling actual native crashes through our native integration, only managed (.NET) exceptions in NativeAOT published apps. In any case, if you have a case that's not captured and should be, please raise an issue, ideally with a reproducible example

@tipa
Copy link

tipa commented Nov 16, 2023

I was just using SentrySdk.CauseCrash(CrashType.Managed) and that didn't show up (only when running in Debug / non-NativeAOT). I'll wait until this PR is merged and a new version is published, then I'll try again.

@vaind vaind force-pushed the feat/net8-ios-aot branch 2 times, most recently from 5262687 to 07a008a Compare November 16, 2023 13:45
@vaind vaind force-pushed the feat/net8-ios-aot branch from 07a008a to b808e21 Compare November 16, 2023 13:49
@vaind vaind marked this pull request as ready for review November 16, 2023 15:02
bitsandfoxes
bitsandfoxes approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

CHANGELOG.md Outdated Show resolved Hide resolved
samples/Sentry.Samples.Maui/Sentry.Samples.Maui.csproj
@@ -58,11 +59,12 @@
<TargetPlatformIdentifier>$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)'))</TargetPlatformIdentifier>

<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'android' And '$(OSArchitecture)' == 'Arm64'">android-arm64</RuntimeIdentifier>
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'ios' And '$(OSArchitecture)' == 'Arm64'">iossimulator-arm64</RuntimeIdentifier>
<RuntimeIdentifier Condition="'$(TargetPlatformIdentifier)' == 'ios' And '$(_IsPublishing)' == 'true'">ios-arm64</RuntimeIdentifier>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we missing an ios-x64 RuntimeIdentifier?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no such thing as x86_64 iphones

@vaind @bitsandfoxes
Update CHANGELOG.md
2749094 
Co-authored-by: Stefan Jandl <[email protected]>
@vaind vaind merged commit 0d643ff into feat/4.0.0 Nov 16, 2023
6 checks passed
@vaind vaind deleted the feat/net8-ios-aot branch November 16, 2023 18:58
@vaind vaind mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaind @tipa @bitsandfoxes