-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IHostBuilder support #1015
Closed
Closed
Add IHostBuilder support #1015
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7c052dd
Draft
Vandersteen efe7497
Merge branch 'main' into feature/hostbuilder
bruno-garcia 79e1ab5
Merge branch 'main' into feature/hostbuilder
Tyrrrz 7726e9a
Update src/Sentry.AspNetCore/SentryHostBuilderExtensions.cs
Vandersteen ee2f2c2
Merge branch 'main' into feature/hostbuilder
Tyrrrz 8e518a2
Make AddSentry on IWebHostBuilder and IHostBuilder idempotent
Vandersteen 7095a47
Fix PR comments
Vandersteen fc84525
Fix samples
Vandersteen 8d3d3de
Added tests and samples
Vandersteen 7fd6cd2
Merge branch 'main' into feature/hostbuilder
Vandersteen 6638eca
Merge branch 'main' into feature/hostbuilder
Tyrrrz 06ca369
Fix tests
Vandersteen 459325b
Merge branch 'feature/hostbuilder' of github.com:Vandersteen/sentry-d…
Vandersteen 824e856
Merge branch 'main' into feature/hostbuilder
Vandersteen d3bc651
Merge branch 'main' into feature/hostbuilder
Tyrrrz 1bfce46
Fix failing tests
Vandersteen ded818b
Merge branch 'main' into feature/hostbuilder
Vandersteen f3dc8d4
Update samples/Sentry.Samples.AspNetCore.Basic/Program.cs
Vandersteen cd4ea2f
Fix Basic sample
Vandersteen 885ace1
Fix conflict
Vandersteen 42a84ba
Fix strange extension
Vandersteen 7c20f88
Merge branch 'main' into feature/hostbuilder
bruno-garcia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
using System.ComponentModel; | ||
using Microsoft.Extensions.Configuration; | ||
using Microsoft.Extensions.DependencyInjection; | ||
using Microsoft.Extensions.Logging; | ||
using Microsoft.Extensions.Logging.Configuration; | ||
using Microsoft.Extensions.Options; | ||
|
||
namespace Sentry.AspNetCore | ||
{ | ||
/// <summary> | ||
/// Extension methods for <see cref="ILoggingBuilder"/> | ||
/// </summary> | ||
[EditorBrowsable(EditorBrowsableState.Never)] | ||
internal static class SentryLoggingBuilderExtensions | ||
{ | ||
public static ISentryBuilder AddSentry(this ILoggingBuilder builder, IConfiguration configuration) | ||
{ | ||
builder.AddConfiguration(); | ||
|
||
var section = configuration.GetSection("Sentry"); | ||
_ = builder.Services.Configure<SentryAspNetCoreOptions>(section); | ||
|
||
if(!builder.Services.IsRegistered<IConfigureOptions<SentryAspNetCoreOptions>, SentryAspNetCoreOptionsSetup>()) | ||
{ | ||
_ = builder.Services | ||
.AddSingleton<IConfigureOptions<SentryAspNetCoreOptions>, SentryAspNetCoreOptionsSetup>(); | ||
} | ||
|
||
if(!builder.Services.IsRegistered<ILoggerProvider, SentryAspNetCoreLoggerProvider>()) | ||
{ | ||
_ = builder.Services.AddSingleton<ILoggerProvider, SentryAspNetCoreLoggerProvider>(); | ||
} | ||
|
||
_ = builder.AddFilter<SentryAspNetCoreLoggerProvider>( | ||
"Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware", | ||
LogLevel.None); | ||
|
||
return builder.Services.AddSentry(); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: one day we'll have a linter that reformats and pushed to the branch :)
Could you please do this throughout the change?