Environment changed to lower case without being mentioned as breaking change? #899
-
EnvironmentHow do you use Sentry? Which SDK and version? Steps to Reproduce
Expected ResultI would expect it to keep the original behavior (i.e. keep "Production"), or at least be mentioned as a breaking change. Actual ResultWe didn't get notified on production issues for over a week, and it took some time to figure out what happened. |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments
-
It was mentioned in releases: https://github.com/getsentry/sentry-dotnet/releases/tag/3.0.0 And also in docs: https://docs.sentry.io/platforms/dotnet/migration/ It was not mentioned in |
Beta Was this translation helpful? Give feedback.
-
Sorry this cause some friction on your alerts. Sentry defaulted in all sdks to See: https://github.com/getsentry/sentry-dotnet/pull/550/files You can keep
|
Beta Was this translation helpful? Give feedback.
-
Ah ok so that's good, then the issue was more that we didn't know where to look. Since you mentioned breaking changes for version 2 in your changelog we assumed that there were no breaking changes in version 3. Perhaps you could link to the release tag from the changelog, and highlight that there's where you can read about breaking changes? (Another question is if Sentry environments really need to be case sensitive?) |
Beta Was this translation helpful? Give feedback.
Sorry this cause some friction on your alerts. Sentry defaulted in all sdks to
production
and for ASP.NET Core that has the same behavior but withProduction
this became a problem and we had to introduce this breakage at somepoint. Since 3.0.0 was landing we decided it was the right time.If you have any other Sentry SDK like JavaScript you'd end up with
Production
andproduction
on the list forever. So we decided to set toproduction
if it wasn't an explicitly set environment, but picked up from ASP.NET Core instead.See: https://github.com/getsentry/sentry-dotnet/pull/550/files
And: https://github.com/getsentry/sentry-dotnet/pull/554/files
You can keep
Production
by setting it explicitl…