Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): Add documentation for new ContextLines integration #7564

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 31, 2023

Adds documentation for the new ContextLines integration which we're going to ship soon (getsentry/sentry-javascript#8699)

ref getsentry/sentry-javascript#8656

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 2:25pm

@Lms24 Lms24 requested review from a team, lforst and AbhiPrasad and removed request for a team July 31, 2023 11:59
@Lms24
Copy link
Member Author

Lms24 commented Jul 31, 2023

Closing for the time being as I had to revert the PR in the SDK. We might drop the feature. I'll reopen if we decide to proceed.

@Lms24 Lms24 closed this Jul 31, 2023
@Lms24 Lms24 reopened this Aug 2, 2023
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now 👍

@Lms24 Lms24 merged commit 7725e68 into master Aug 10, 2023
6 checks passed
@Lms24 Lms24 deleted the lms/feat-browser-contextlines-doc branch August 10, 2023 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants