Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): Add docs for Swift Error description #6805

Merged
merged 12 commits into from
May 10, 2023

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented May 3, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Sentry Cocoa 8.7.0 contains improvements for Swift error descriptions. This PR adds the docs for this feature. Please only merge this PR after releasing 8.7.0.

Sentry Cocoa 8.7.0 contains improvements for Swift error
descriptions. This PR adds the docs for this feature.
@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 1:34pm

@philipphofmann philipphofmann requested review from a team May 3, 2023 10:07
Comment on lines +79 to +89
<PlatformSection supported={["apple.macos"]}>

## Capturing Uncaught Exceptions in macOS

By default, macOS applications do not crash whenever an uncaught exception occurs. To enable this with Sentry:

1. Open the application's `Info.plist` file
2. Search for `Principal class` (the entry is expected to be `NSApplication`)
3. Replace `NSApplication` with `SentryCrashExceptionApplication`

</PlatformSection>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this existing section down here.

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small tweaks

src/platform-includes/capture-error/apple.mdx Outdated Show resolved Hide resolved
src/platform-includes/capture-error/apple.mdx Outdated Show resolved Hide resolved
src/platform-includes/capture-error/apple.mdx Show resolved Hide resolved
src/platform-includes/capture-error/apple.mdx Outdated Show resolved Hide resolved
@philipphofmann
Copy link
Member Author

Thanks a lot for the review @shanamatthews 👏

@philipphofmann philipphofmann merged commit 3894b0d into master May 10, 2023
@philipphofmann philipphofmann deleted the feat/swift-errors branch May 10, 2023 04:24
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants