-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for OpenTelemetry Java #5968
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
...ludes/performance/opentelemetry-setup/with-java-agent/without-auto-init/java.spring-boot.mdx
Outdated
Show resolved
Hide resolved
sentry.instrumenter=otel | ||
``` | ||
|
||
You also have to manually provide the `OpenTelemetryLinkErrorEventProcessor` bean to ensure errors are properly linked to transactions that were created by the OpenTelemetry integration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to keep this as is for now as there doesn't seem to be an easy way to detect whether the sentry-opentelemetry-agent
is used or not and this seems like a rather niche use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my suggestions.
src/platforms/java/common/performance/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
src/platforms/java/common/performance/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
src/platforms/java/common/performance/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
@@ -0,0 +1 @@ | |||
You can download the latest version of the `sentry-opentelemetry-agent-{{ packages.version('sentry.java.opentelemetry-agent') }}.zip` from [GitHub](https://github.com/getsentry/sentry-java/releases/) which contains the `JAR` file used in this docs page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to double check that we're pointing to the right page. I don't see a .zip file named "sentry.java.opentelemetry-agent", but it may be part of one of the other files. Just wanted to make sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only visible if you hit "Show all 33 assets".
src/platforms/java/common/performance/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
...ludes/performance/opentelemetry-setup/with-java-agent/without-auto-init/java.spring-boot.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/opentelemetry-setup/without-java-agent/java.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/opentelemetry-setup/without-java-agent/java.spring-boot.mdx
Outdated
Show resolved
Hide resolved
#### Initializing OpenTelemetry | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to add an introductory sentence before the code snippet to give the user more context and an easier way to scan the page.
|
||
<PlatformContent includePath="performance/opentelemetry-install/without-java-agent" /> | ||
|
||
### Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to add an introductory sentence to introduce the user to the section and make the page easier to read. Please avoid stacking headings without text in-between.
…metry.mdx Co-authored-by: Liza Mock <[email protected]>
src/platforms/java/common/performance/instrumentation/opentelemetry.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liza Mock <[email protected]>
@lizokm I've updated the PR, can you please give the changes another pass 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Going to merge now, if you have any more feedback just let me know. I can improve docs in another PR if needed but would like to merge this now in case people need the docs during holidays. |
Java SDK has added support for OpenTelemetry, these are the docs for it :-)