ref: make Platform related content use the event system #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronmcefee
commented
Sep 11, 2018
| this.setAttribute('data-config-key', $(this).text()); | ||
| }); | ||
|
|
||
| $('.unsupported-hint').remove(); |
There was a problem hiding this comment.
This is the one functional change I made. Since we're firing this off whenever the platform changes, we'll need to remove the previous elements so we don't keep adding them on top of one another.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to move stuff away from using init functions because most of the JS really needs to run whenever the page updates. This moves the platform related content into the method that fires every time there's a page update or when the platform changes.