feat: Add Electron docs #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
requested review from
mitsuhiko,
dcramer,
cameronmcefee,
HazAT and
rsomething
mitsuhiko
approved these changes
Mar 13, 2018
|
I think also someone recently made the sidebar manual and it needs adding to the layout template too |
|
Any chance you have a screenshot handy for reviewing the design changes I assume you pinged me for? It'll probably take me half the day to get the environment running again |
|
There are two problems:
Let me update the description for screenshots. |
|
Description updated. |
|
@cameronmcefee mostly pinged you because of the icon. We should consider adding the actual electron icon to the icon library. |
|
👍 noted |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds docs for our new Electron SDK and replaces the old ones.
See getsentry/sentry-javascript#1241 for the deletion PR.
Thanks @HazAT for putting together the docs.
Screenshot of the clients menu
Screenshot of the docs page
(sorry for the bad quality, Chrome's full-size screenshot didn't work)