Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Document Vercel AI integration #12087

Merged
merged 3 commits into from
Dec 12, 2024
Merged

feat: Document Vercel AI integration #12087

merged 3 commits into from
Dec 12, 2024

Conversation

AbhiPrasad
Copy link
Member

DESCRIBE YOUR PR

Documents Vercel AI integration added with getsentry/sentry-javascript#13892

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@AbhiPrasad AbhiPrasad requested a review from a team December 10, 2024 20:25
@AbhiPrasad AbhiPrasad self-assigned this Dec 10, 2024
@AbhiPrasad AbhiPrasad requested review from Lms24 and s1gr1d and removed request for a team December 10, 2024 20:25
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:38pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 2:38pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 2:38pm

Copy link

codecov bot commented Dec 10, 2024

Bundle Report

Changes will increase total bundle size by 246 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 252 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the add 🫡

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: Shouldn't this page be part of the "Integrations" section rather than directly in "Configuration"?

Otherwise, if we have already settled on putting this directly under "Confuguration", can we move it down a bit? I don't think this should be directly under "Basic Options".

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup wrong path 🤦 - will fix!


## Supported Versions

- `dataloader`: `>=3.0.0 <5`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Maybe I'm missing something here but is dataloader a transitive dependency of ai? Might be worth to add a sentence or two to explain what it is. Also, does this translate to an ai version range we could mention instead?

Actually I saw that we mention dataloader in other pages as well. Any chance this was a copy/paste leftover? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy-paste mistake! will fix

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 12, 2024 14:11
@AbhiPrasad AbhiPrasad merged commit 71f3501 into master Dec 12, 2024
11 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-vercel-ai-doc branch December 12, 2024 14:39
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants