Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(relay): update the data scrubbing default values #11949

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinhaintz
Copy link
Collaborator

Update the data scrubbing default values

After investigating a data scrubbing issue I found out, that the list in the docs differs from the list defined in the relay code.

list in the current docs:

  - password
  - secret
  - passwd
  - api_key
  - apikey
  - access_token
  - auth
  - credentials
  - mysql_pwd
  - stripetoken
  - card[number]
  - github_token
  - privatekey
  - private_key

list in the current relay code:

password|secret|passwd|api_key|apikey|auth|credentials|mysql_pwd|privatekey|private_key|token|bearer

comparing these two lists I updated the docs and removed:

- access_token
- stripetoken
- card[number]
- github_token

and added these:

- token
- bearer

@iambriccardo can you have a look and verify that my assumptions are correct?

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 10:54am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Nov 26, 2024 10:54am
develop-docs ⬜️ Ignored (Inspect) Nov 26, 2024 10:54am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants