Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sdks): Span Sampling #11940

Merged
merged 5 commits into from
Nov 26, 2024
Merged

docs(sdks): Span Sampling #11940

merged 5 commits into from
Nov 26, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Nov 25, 2024

Parts of the this PR were transferred to #11912.
This includes the propagated sampling rate as well as strict trace propagation.

@cleptric cleptric self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 10:10am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:10am
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 10:10am

- The APIs are optimized for trace completeness
- The APIs are optimized for conclusive sampling decisions

## Sample root spans with `tracesSampleRate` & `tracesSampler`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this gets merged, I would love it if this section contained one or two paragraphs on the goals of the API & behavior. As it stands, this reads very much like a "do this" with no context whatsoever but I assume this is due to it being WIP.

from @lforst previous PR comment

@stephanie-anderson stephanie-anderson marked this pull request as ready for review November 26, 2024 10:15
@stephanie-anderson stephanie-anderson merged commit d92a2eb into master Nov 26, 2024
10 checks passed
@stephanie-anderson stephanie-anderson deleted the span-sampling branch November 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants