Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): Update SDK provider setup docs for Angular 19 #11921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 22, 2024

DESCRIBE YOUR PR

This PR updates the Angular provider setup in the Angular "Getting Started" docs page. In Angular 19, the APP_INITIALIZER DI token was deprecated and the new recommended way to provide a dependency (our TraceService) at app start is to use provideAppInitializer and the inject API.

To be clear, this is not a breaking change. But it makes sense for us to document the most up to date way as well.

Also made a minor wording change in the compatibility note

Our SDK is comaptible with Angular 19 since v8.40.0, so this PR can be merged whenever it's approved.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:29pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 4:29pm
develop-docs ⬜️ Ignored (Inspect) Nov 22, 2024 4:29pm

@Lms24 Lms24 self-assigned this Nov 22, 2024
@Lms24 Lms24 requested review from lforst and s1gr1d November 22, 2024 16:18
@Lms24 Lms24 changed the title feat(angular): Update SDK provider setup for Angular 19 feat(angular): Update SDK provider setup docs for Angular 19 Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.13MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.02MB 6 bytes (-0.0%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant