API examples syntax highlighting #11715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 104.91kB (0.7%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
chargome
approved these changes
Nov 4, 2024
martinhaintz
pushed a commit
that referenced
this pull request
Nov 5, 2024
* master: (213 commits) Remove feature flag documentation from issue details page (#11734) docs(insights): Remove EA note from Queries re: MongoDB (#11735) docs(nuxt): `piniaIntegration` in Nuxt (#11684) feat(flags): Add OpenFeature and LaunchDarkly integration documentation (#11675) Cleaning up mermaid code and made it a bit more readable in dark mode (#11726) docs(scopes): Add graphics for scope forking (#11702) Unreal Engine plugin documentation update (#11625) Bump API schema to 25e528ff (#11728) Bump API schema to 12bd311c (#11725) fix dark theme resolution (#11718) Update sign in to go to sentry (#11723) getsentry/relay@4bdad17 API examples syntax highlighting (#11715) feat: Convert mermaid code blocks to SVGs client side (#11690) Trace context is required for transactions (#11456) deps: Bump SDK to 8.36.0 (#11696) getsentry/relay@2e2587c MAUI screenshot `SetBeforeScreenshotCapture`(#11672) Add CSS rule to fix color of bold links (#11707) Fix small typo on web-vitals-concepts (#11706) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent was to unify the syntax highlighting logic for API examples and other docs,
but API examples have specific requirements that prevent us from reusing existing logic
code blocks are usually handled though
CodeTabs, which adds tabs and manages the corresponding code blocks, but we need more tabs (api responses for example)The curl bash snippet was possible to handle using a simple
CodeBlockI tried to use the same syntax highlighting libraries (using refractor) server side, and gave the API examples code blocks the same look and behavior as elsewhere
verify here
closes #11093