Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): Document kafkajs integration #11350

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

DESCRIBE YOUR PR

Documents getsentry/sentry-javascript#13528

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@AbhiPrasad AbhiPrasad requested review from a team, lforst and s1gr1d and removed request for a team September 13, 2024 08:52
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 9:08am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 9:08am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Sep 13, 2024 9:08am

Copy link

codecov bot commented Sep 13, 2024

Bundle Report

Changes will increase total bundle size by 233 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 242 bytes ⬆️
sentry-docs-edge-server-array-push 257.01kB 3 bytes ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes ⬇️

@AbhiPrasad AbhiPrasad merged commit 2f2fed8 into master Sep 13, 2024
10 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-kafka-integration-js branch September 13, 2024 11:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants