Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of Concept: Frame Tracking #699

Closed
wants to merge 6 commits into from

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Jan 16, 2022

This PR shows how one could add the 'total frames' measurement for transactions.
The current code needs some more polishing before it's ready for release.
I'm currently not able to finish this, so I would appreciate it, if someone else would take it over the finishing line.

This also seems to require some (bigger?) changes in the transaction/span API. It's also tricky to get the total frame number with auto closing navigation transaction, because there's no callback.

screenshot

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2022

Codecov Report

Merging #699 (f49a663) into main (6206e85) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   90.70%   90.96%   +0.26%     
==========================================
  Files         104        8      -96     
  Lines        3336      155    -3181     
==========================================
- Hits         3026      141    -2885     
+ Misses        310       14     -296     
Impacted Files Coverage Δ
dart/lib/src/protocol/sentry_transaction.dart
dart/lib/src/sentry_tracer.dart
.../lib/src/navigation/sentry_navigator_observer.dart
flutter/lib/src/sentry_asset_bundle.dart
dart/lib/src/sentry_user_feedback.dart
flutter/lib/src/sentry_flutter.dart
dart/lib/src/protocol/sentry_browser.dart
flutter/lib/src/sentry_flutter_options.dart
dart/lib/src/http_client/sentry_http_client.dart
...ib/src/environment/_web_environment_variables.dart
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6206e85...f49a663. Read the comment docs.

@marandaneto
Copy link
Contributor

@denrase you probably want to check that out since we'd need something similar for the Mobile vitals.


// postFrameCallbacks are called just once,
// so we have to add it each frame.
_binding.addPostFrameCallback(_frameCallback);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a ticker is a better candidate than this? See https://api.flutter.dev/flutter/scheduler/Ticker-class.html

@ueman
Copy link
Collaborator Author

ueman commented Mar 18, 2022

This feature was implemented with a different approach.

@ueman ueman closed this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants