Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Always call Flutter.onError #533

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Jul 19, 2021

📜 Description

See motivation

💡 Motivation and Context

Closes #522

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@ueman ueman requested a review from marandaneto as a code owner July 19, 2021 09:44
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #533 (b75202e) into main (d5416f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files          74       74           
  Lines        2426     2426           
=======================================
  Hits         2221     2221           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5416f8...b75202e. Read the comment docs.

@ueman ueman merged commit 13a9705 into main Jul 19, 2021
@ueman ueman deleted the fix/522-call-flutter-on-error-handler branch July 19, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentry_flutter: Invoke default FlutterError.onError even if reportSilentFlutterErrors is false
3 participants