Record dropped spans in client reports

[buenaflor]

📜 Description

Reports the dropped spans as well in client reports, not only the transaction

For all platforms this change reports dropped spans through:

• sampling
• beforeSend/beforeSendTransaction -> either dropping the whole transaction or keeping the transaction but only dropping a few spans
• event processors with same report behaviour as beforeSend

For Web, Linux, Windows (through HttpTransport):

• rate limiter
• network errors

rate limit or network errors on ios, macos or android are handled by the native sdks

💡 Motivation and Context

Related #2137

💚 How did you test it?

Unit tests

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
• I updated the docs if needed
• All tests passing
• No breaking changes

🔮 Next steps

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 03a297d

[codecov]

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.34%. Comparing base (3d305b9) to head (03a297d).
Report is 2 commits behind head on main.

Files	Patch %	Lines
dart/lib/src/client_reports/discarded_event.dart	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   88.31%   88.34%   +0.03%     
==========================================
  Files         225      226       +1     
  Lines        7778     7816      +38     
==========================================
+ Hits         6869     6905      +36     
- Misses        909      911       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.60 ms	1239.00 ms	16.40 ms
Size	8.33 MiB	9.63 MiB	1.29 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
31b2afb	1244.90 ms	1261.37 ms	16.47 ms
683fd34	1239.83 ms	1259.08 ms	19.25 ms
b0811cc	1238.23 ms	1255.82 ms	17.59 ms
84bc635	1252.26 ms	1273.96 ms	21.70 ms
9fe67d5	1242.33 ms	1268.77 ms	26.44 ms
40680d3	1243.22 ms	1257.02 ms	13.80 ms
f0fcbe1	1238.08 ms	1243.44 ms	5.36 ms
eb1a7c1	1281.25 ms	1295.40 ms	14.15 ms
9c5aec6	1266.51 ms	1274.65 ms	8.14 ms
8776cdf	1237.64 ms	1246.83 ms	9.20 ms

App size

Revision	Plain	With Sentry	Diff
31b2afb	8.33 MiB	9.40 MiB	1.07 MiB
683fd34	8.28 MiB	9.34 MiB	1.06 MiB
b0811cc	8.32 MiB	9.38 MiB	1.06 MiB
84bc635	8.33 MiB	9.40 MiB	1.07 MiB
9fe67d5	8.32 MiB	9.50 MiB	1.18 MiB
40680d3	8.10 MiB	9.16 MiB	1.07 MiB
f0fcbe1	8.29 MiB	9.38 MiB	1.09 MiB
eb1a7c1	8.15 MiB	9.13 MiB	1000.10 KiB
9c5aec6	8.15 MiB	9.12 MiB	986.23 KiB
8776cdf	8.33 MiB	9.40 MiB	1.07 MiB

Previous results on branch: feat/report-dropped-spans

Startup times

Revision	Plain	With Sentry	Diff
783e595	1227.40 ms	1250.12 ms	22.72 ms
d8744bf	1227.43 ms	1243.02 ms	15.59 ms
1e0eafe	1226.29 ms	1252.02 ms	25.73 ms
8ad162f	1250.43 ms	1262.22 ms	11.80 ms

App size

Revision	Plain	With Sentry	Diff
783e595	8.33 MiB	9.63 MiB	1.29 MiB
d8744bf	8.33 MiB	9.63 MiB	1.29 MiB
1e0eafe	8.33 MiB	9.63 MiB	1.29 MiB
8ad162f	8.33 MiB	9.63 MiB	1.29 MiB

[github-actions]

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	410.16 ms	481.39 ms	71.22 ms
Size	6.35 MiB	7.35 MiB	1021.52 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
c1bb00f	303.77 ms	371.88 ms	68.11 ms
62de927	313.81 ms	358.15 ms	44.34 ms
7748b7c	356.37 ms	426.70 ms	70.33 ms
1cdcacf	389.94 ms	463.53 ms	73.59 ms
6325c3b	339.33 ms	409.86 ms	70.53 ms
f6f3d25	349.44 ms	438.90 ms	89.46 ms
b728df4	390.98 ms	445.81 ms	54.83 ms
ed2ae08	360.06 ms	440.92 ms	80.86 ms
8f88a49	364.98 ms	413.78 ms	48.80 ms
636cb61	366.59 ms	448.14 ms	81.55 ms

App size

Revision	Plain	With Sentry	Diff
c1bb00f	6.06 MiB	7.09 MiB	1.03 MiB
62de927	6.15 MiB	7.11 MiB	981.78 KiB
7748b7c	6.27 MiB	7.20 MiB	959.09 KiB
1cdcacf	6.33 MiB	7.26 MiB	949.77 KiB
6325c3b	5.94 MiB	6.96 MiB	1.02 MiB
f6f3d25	6.27 MiB	7.20 MiB	958.60 KiB
b728df4	5.94 MiB	6.95 MiB	1.01 MiB
ed2ae08	6.27 MiB	7.20 MiB	958.73 KiB
8f88a49	6.34 MiB	7.30 MiB	979.60 KiB
636cb61	6.27 MiB	7.20 MiB	959.08 KiB

Previous results on branch: feat/report-dropped-spans

Startup times

Revision	Plain	With Sentry	Diff
d8744bf	382.70 ms	465.28 ms	82.58 ms
783e595	413.77 ms	508.18 ms	94.41 ms
1e0eafe	445.67 ms	490.29 ms	44.62 ms
8ad162f	413.70 ms	496.67 ms	82.97 ms

App size

Revision	Plain	With Sentry	Diff
d8744bf	6.35 MiB	7.35 MiB	1021.17 KiB
783e595	6.35 MiB	7.35 MiB	1021.40 KiB
1e0eafe	6.35 MiB	7.35 MiB	1021.42 KiB
8ad162f	6.35 MiB	7.35 MiB	1019.05 KiB

[buenaflor]

used so we don't have to deserialize the envelope when we want to access the number of spans in a transaction for example

[buenaflor]

@stefanosiano hey could you review this one for me since you did the implementation on java/android as well pls 🙏

[stefanosiano]

Can you add the same logic of the beforeSend callback here?
report discarded spans from a processor even if the transaction is not dropped
(note that computation should continue in that case, so no need to break)

[stefanosiano]

Very good!
Just add the case of dropped span in event processor and you're good to go!