-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize sensitive data from URLs (span desc, span data, crumbs, client errors) #1327
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
- Coverage 89.78% 89.74% -0.04%
==========================================
Files 177 59 -118
Lines 5676 2009 -3667
==========================================
- Hits 5096 1803 -3293
+ Misses 580 206 -374
... and 118 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @adinauer
@denrase after addressing #1327 (comment) and making CI happy, we can merge it :)
…sentry/sentry-dart into feat/remove-sensitive-data-from-urls
📜 Description
authorization
,Authorization
,cookies
,Cookies
,cookie
,Cookie
header fields💡 Motivation and Context
Fixes #1171
Based on the implementation of getsentry/sentry-java#2365
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPii
is enabledWhats next?
In the spec the field is called
Cookies
, but elsewhere i have found it defined asCookie
. Opted to remove both versions for now.