Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run metrics on forks #1075

Merged
merged 1 commit into from
Oct 13, 2022
Merged

ci: don't run metrics on forks #1075

merged 1 commit into from
Oct 13, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Oct 12, 2022

Trying out if this could be a solution to only run metrics on pushes to the repo instead of on forks. Currently, I suspect it may fail because some GHA context var won't be set to an expected value if it's not on a PR.

See also #1073 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 89.97% // Head: 89.97% // No change to project coverage 👍

Coverage data is based on head (55d7053) compared to base (5d15a51).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1075   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files         115      115           
  Lines        3582     3582           
=======================================
  Hits         3223     3223           
  Misses        359      359           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 344.04 ms 384.84 ms 40.80 ms
Size 5.94 MiB 6.92 MiB 1003.76 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9c5aec6 287.33 ms 320.94 ms 33.61 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
56810ff 309.72 ms 352.26 ms 42.54 ms
3e5ee37 317.56 ms 366.84 ms 49.28 ms
6d317ea 303.46 ms 356.06 ms 52.60 ms
72dfc83 298.62 ms 340.14 ms 41.52 ms
49a149b 301.96 ms 344.51 ms 42.55 ms
1c6eb5b 350.69 ms 393.86 ms 43.17 ms
af2d175 279.08 ms 312.37 ms 33.29 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms

App size

Revision Plain With Sentry Diff
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
56810ff 5.94 MiB 6.92 MiB 1001.71 KiB
3e5ee37 5.94 MiB 6.92 MiB 1001.19 KiB
6d317ea 5.94 MiB 6.92 MiB 1001.74 KiB
72dfc83 5.94 MiB 6.92 MiB 1001.71 KiB
49a149b 5.94 MiB 6.92 MiB 1001.54 KiB
1c6eb5b 5.94 MiB 6.92 MiB 1001.53 KiB
af2d175 5.94 MiB 6.92 MiB 1001.83 KiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB

Previous results on branch: ci/metrics-no-forks

Startup times

Revision Plain With Sentry Diff
b4e2a98 334.40 ms 417.92 ms 83.52 ms

App size

Revision Plain With Sentry Diff
b4e2a98 5.94 MiB 6.92 MiB 1001.71 KiB

@vaind vaind marked this pull request as ready for review October 12, 2022 17:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1270.76 ms 1293.39 ms 22.64 ms
Size 8.15 MiB 9.12 MiB 991.36 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
af2d175 1280.37 ms 1282.24 ms 1.88 ms
633cf2e 1257.96 ms 1275.73 ms 17.77 ms
49a149b 1296.47 ms 1320.20 ms 23.73 ms
56810ff 1267.59 ms 1293.48 ms 25.89 ms
559d28f 1265.04 ms 1288.96 ms 23.92 ms
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms
9c5aec6 1266.51 ms 1274.65 ms 8.14 ms
72dfc83 1262.50 ms 1289.75 ms 27.25 ms
1c6eb5b 1277.85 ms 1285.71 ms 7.86 ms
6d317ea 1277.27 ms 1287.47 ms 10.20 ms

App size

Revision Plain With Sentry Diff
af2d175 8.15 MiB 9.12 MiB 986.22 KiB
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB
49a149b 8.15 MiB 9.12 MiB 986.26 KiB
56810ff 8.15 MiB 9.12 MiB 987.35 KiB
559d28f 8.15 MiB 9.12 MiB 987.32 KiB
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB
9c5aec6 8.15 MiB 9.12 MiB 986.23 KiB
72dfc83 8.15 MiB 9.12 MiB 987.30 KiB
1c6eb5b 8.15 MiB 9.12 MiB 986.27 KiB
6d317ea 8.15 MiB 9.12 MiB 986.26 KiB

Previous results on branch: ci/metrics-no-forks

Startup times

Revision Plain With Sentry Diff
b4e2a98 1267.43 ms 1279.10 ms 11.68 ms

App size

Revision Plain With Sentry Diff
b4e2a98 8.15 MiB 9.12 MiB 987.34 KiB

@marandaneto marandaneto merged commit 21845e2 into main Oct 13, 2022
@marandaneto marandaneto deleted the ci/metrics-no-forks branch October 13, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants