Request for Custom SpanStatus Constuctor

[ostk0069]

Problem Statement

by looking at https://github.com/getsentry/sentry-dart/blob/main/dart/lib/src/protocol/span_status.dart ,
SpanStatus only support custom SpanStatus with SpanStatus.fromString().
Our project has original HttpStatus to handle.
Is there any problem to create constructor for both value and httpStatusCode.

Solution Brainstorm

add constructor for SpanStatus with

/// Creates SpanStatus from both String and httpStatusCode.
  factory SpanStatus.custom(String value, int httpStatusCode) => SpanStatus._(value, httpStatusCode);

Are you willing to submit a PR?

Yes

[ostk0069]

I would like to create a PR, if there is no problem with it
So, please let me know.

[krystofwoldrich]

Hi,
thank you for the message,
what you are suggesting looks to me like SpanStatus.fromHttpStatusCode(statusCode)? Or did I misunderstand?

sentry-dart/dart/lib/src/protocol/span_status.dart

Line 85 in 77ab5a0

factory SpanStatus.fromHttpStatusCode(

[ostk0069]

what you are suggesting looks to me like SpanStatus.fromHttpStatusCode(statusCode)? Or did I misunderstand?

our project has original http status which is not included in https://github.com/getsentry/sentry-dart/blob/main/dart/lib/src/protocol/span_status.dart 😢

[marandaneto]

@ostk0069 the Sentry's span status is a sentry protocol, it does not map 1:1 to the HTTP spec.
https://develop.sentry.dev/sdk/event-payloads/span/
We will eventually simplify this: getsentry/develop#383 but we are not there yet.
So you may use the one that is close enough and has the same meaning for now.